Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of {{{ }}} in the html report #1188

Closed
ebidel opened this issue Dec 20, 2016 · 2 comments
Closed

Remove usage of {{{ }}} in the html report #1188

ebidel opened this issue Dec 20, 2016 · 2 comments
Assignees
Labels

Comments

@ebidel
Copy link
Contributor

ebidel commented Dec 20, 2016

In some places we use {{{}}} to render our own data (example). Those are fine.

However, we should remove {{{ }}} in places where we render user data (example]. Those are there to render code snippets and links in helpText and audit descriptions. Instead, we should create Handlebar helpers to render links and code snippets.

http://handlebarsjs.com/reference.html#base-escapeExpression

This works today if it appears in json loaded into the app:

"helpText": "<img src=\"test.gif\" onerror=\"alert('oops')\"> Text..."

@wardpeet
Copy link
Collaborator

Are you going to take this @ebidel ? :)

@ebidel
Copy link
Contributor Author

ebidel commented Dec 21, 2016

Yea. started in on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants