Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageElement gathererer fixups #12077

Closed
paulirish opened this issue Feb 10, 2021 · 0 comments · Fixed by #12568
Closed

ImageElement gathererer fixups #12077

paulirish opened this issue Feb 10, 2021 · 0 comments · Fixed by #12568

Comments

@paulirish
Copy link
Member

some ideas from #12065 (comment)

we could do a minor rethink of the shape and types.

  • idea for imageElement.cssSizing obj width width/height props.. obj is appropriately null/undefined if skipped etc.
    • obj could include the naturalWidth bits as well and be fetchedDimensions or we keep 'em separate.
  • maybe same idea for attributeWidth/etc as those don't make sense for isCss images?
  • naturalWidth/naturalHeight is in a similar but not quite the same situation as cssWidth/cssHeight after core(image-elements): set 5s time budget, add _privateCssSizing #12065
  • to add to the null/undefined confusion, don't forget the return value of el.getAttribute('notASetAttribute')
  • '' is a bad value for attribute* for css. and also bad for html images.. should fall through to null, as getAttribute dictates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants