Anchors with no href fail AnchorsWithNoRelOpener Audit

[ebidel]

Testing https://www.seamless.com/, we get:

@brendankenny giving this to you since you already started investigating.

[brendankenny]

The underlying issue here is new URL(''), which isn't valid, which happens when you use an anchor tag without an href attribute.

The issue is that many web apps use anchors with no href for app purposes (e.g. the seamless example has <a class="app-download-appsStore-link" ng-click="::$ctrl.goToUrl($ctrl.appleUrl)" target="_blank">...</a>). However angular, at least, still honors the target attribute (and window.opener is available in the new tab). If it honors rel as well we should probably still warn on these links, so we shouldn't just strip them out in the audit.

[wardpeet]

issue got fixed on master