-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service worker registered too late for Lighthouse to detect #13138
Comments
@SirJackovich and I are on similar type teams within FamilySearch, and we are experiencing this with our app as well (although it is still very much a work in progress -- in beta -- the link is here): |
Any news on this issue? I'm also running an app, currently testing PWA capabilities on my QA environment, and the app is installable, the service worker seems to work correctly, but according to Lighthouse, it's missing the service worker. I'd also like to note that explicitly when running the Lighthouse report for PWAs, I'm getting an error running my service worker registration script. Although, when running the website normally, no such error occurs, and I can also see on the devtools that the app is installable |
@Heatmanofurioso Thanks for the report, that error case does look interesting, however without a URL for us to poke and prod at debugging is impossible for us :( Is there anyway you can make a smaller repro case and share, or give us access to this QA env? Do you see the same using the latest Lighthouse Node CLI? |
Hi @connorjclark First off, thank you for taking time to check this out As for the link for my QA. It is the following |
@connorjclark I'd like to confirm that running on the latest Node CLI app, I do get a correct response saying my app is valid as a PWA. The specs are as following "Same ones used to run the browser app":
|
Any possible news on this issue? Would it still be useful to make a reproducible example? |
The issue seems to haven been fixed somehow on Web.dev and running the Chrome tool. I have made no change to my production code whatsoever |
In the image in your original post, what was the "1 reason" Lighthouse found? Do you recall? #13396 details a bug we have running LH in DevTools on pages w/ service workers. EDIT
Ah, ok. So it's working for you now in Stable or Canary? When was the last time it wasn't working? |
Lighthouse was saying it couldn't find the service worker, if I recall correctly. It's running fine in stable, I believe. |
Was it "Lighthouse could not determine if there was a service worker. Please try with a newer version of Chrome." if so, that was the error added in #13396. It would make sense why the issue was fixed in that case. For https://beta.familysearch.org/africa/ and https://beta.familysearch.org/discovery/kids, it looks like the service worker takes too long to register so Lighthouse doesn't notice it. We could mention that as a possible reason for failure in the message. Beyond that I'm not sure if there is much we can do here. Maybe we could look for pending service workers somehow? |
With no update on my app regarding this, it started working. So, I assume a fix somewhere on Lighthouse's side was done? |
Based on what you've reported it was most likely #13396. |
As per Chrome’s updated Installability Criteria, Lighthouse will be deprecating the PWA category in the next upcoming release. For future PWA testing, users will be directed to use the updated PWA documentation. Marking this as closed! |
FAQ
URL
https://beta.familysearch.org/africa/
What happened?
I have built a PWA that is installable but when I run the lighthouse check it fails saying it is not installable.
What did you expect?
I expected the check to pass, the app is installable but for some reason lighthouse does not think it is.
What have you tried?
Updating the manifest.json with different config options.
How were you running Lighthouse?
Chrome DevTools
Lighthouse Version
8.3.0
Chrome Version
Version 94.0.4606.61 (Official Build) (x86_64)
Node Version
14
Relevant log output
No response
The text was updated successfully, but these errors were encountered: