Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InspectorIssues protocol no longer contains message strings for deprecations #13895

Closed
connorjclark opened this issue Apr 21, 2022 · 2 comments · Fixed by #13961
Closed

InspectorIssues protocol no longer contains message strings for deprecations #13895

connorjclark opened this issue Apr 21, 2022 · 2 comments · Fixed by #13961
Assignees
Labels
P1.5 test backlog disabled or needed tests

Comments

@connorjclark
Copy link
Collaborator

connorjclark commented Apr 21, 2022

This is the cause of the current dbw deprecations smoke failure.

These have been deprecated. They were english only, and as part of i18n work now clients are expected to provide them (and localize).

This CL removed the strings from deprecations. This is the only inspector type for which we rely on a message field.

DevTools frontend hasn't landed these strings yet, but they should end up here soon. (pending CL) We could parse that file for UIStrings in our collect strings script.

@connorjclark
Copy link
Collaborator Author

Let's just copy/paste the UIStrings into our source tree. That's what we did for installability errors. And then we don't have to figure out how to require the chrome devtools frontend module (which collect-strings would need to do).

@brendankenny
Copy link
Member

And then we don't have to figure out how to require the chrome devtools frontend module (which collect-strings would need to do)

Sounds terrible

Let's just copy/paste the UIStrings into our source tree. That's what we did for installability errors.

Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1.5 test backlog disabled or needed tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants