Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set pubads to official release #14375

Closed
connorjclark opened this issue Sep 8, 2022 · 1 comment
Closed

set pubads to official release #14375

connorjclark opened this issue Sep 8, 2022 · 1 comment
Assignees
@connorjclark
Labels
P1.5 test backlog disabled or needed tests

Comments

@connorjclark
Copy link
Collaborator

connorjclark commented Sep 8, 2022 •
edited by adamraine
Loading

ref https://github.com/GoogleChrome/lighthouse/pull/14241/files#r966490737 and https://github.com/GoogleChrome/lighthouse/pull/14413/files#r989549611
@connorjclark connorjclark mentioned this issue Sep 8, 2022
Merged
@connorjclark connorjclark mentioned this issue Oct 6, 2022
Merged
@brendankenny brendankenny mentioned this issue Jan 23, 2023
Merged
@connorjclark
Copy link
Collaborator Author

@adamraine is updating pubads right now to latest nightly, which will involve proper type checking. Their old typing had a lot of loose types, which now reveal a lot of changes that should be made to get passing types.

We're just gonna do that small thing on our side to keep pubads working, and will get pubads fixed post-10.0

@connorjclark connorjclark removed the 10.0 label Jan 23, 2023
@brendankenny brendankenny added 10.1 P1.5 test backlog disabled or needed tests and removed needs-priority labels Jan 24, 2023
@adamraine adamraine removed the 10.1 label Mar 29, 2023
@adamraine adamraine assigned adamraine and unassigned brendankenny Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connorjclark connorjclark

Labels
P1.5 test backlog disabled or needed tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brendankenny @connorjclark @adamraine @devtools-bot