Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkElements gatherer encountered an error: Expected attribute delimiter at offset 94 #14934

Closed
2 tasks done
mattzeunert opened this issue Mar 28, 2023 · 5 comments · Fixed by #14973
Closed
2 tasks done
Assignees
Labels

Comments

@mattzeunert
Copy link
Contributor

mattzeunert commented Mar 28, 2023

FAQ

URL

https://calendly.com/matt-665/debugbear-demo?month=2023-03

What happened?

Run lighthouse --view https://calendly.com/matt-665/debugbear-demo\?month\=2023-03

There's no SEO score:

Screenshot 2023-03-28 at 10 31 32

What did you expect?

An SEO score should be reported, it worked with Lighthouse 10.0.1.

Started seeing this error on bunch of pages when trying to upgrade to 10.1.0.

What have you tried?

No response

How were you running Lighthouse?

CLI

Lighthouse Version

10.1.0

Chrome Version

114

Node Version

No response

OS

No response

Relevant log output

No response

@brendankenny
Copy link
Member

Thanks @mattzeunert! Looks like this is due to updating http-link-header in 10.1.0.

From the example page, it's attempting to parse the header <https://assets.calendly.com/assets/booking/css/booking-5e8a798d.css>; rel=preload; as=style; nopush and throwing when it doesn't find a '=' after nopush.

I haven't looked into why it got stricter on this. The error condition looks like it was in the old version as well, so something else must have gotten stricter/changed requirements and led back to that code path.

@adamraine
Copy link
Member

@noon92
Copy link

noon92 commented Apr 16, 2023

@adamraine
Copy link
Member

@nagumii Lighthouse 10.1.1 isn't in pagespeed yet, that will probably be updated this week.

@noon92
Copy link

noon92 commented Apr 17, 2023

Thanks, appreciate the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants