Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requestCount to third-party-summary subitem attributes #15093

Closed
benschwarz opened this issue May 18, 2023 · 4 comments · Fixed by #15105
Closed

Add requestCount to third-party-summary subitem attributes #15093

benschwarz opened this issue May 18, 2023 · 4 comments · Fixed by #15105

Comments

@benschwarz
Copy link
Contributor

Feature request summary

At the moment, third-party-summary does not display subitems when files are "too small", or there aren't any numbers to report.

Because of this, it's not currently possible to easily understand the number of requests a given third party made. mainThreadTime, blockingTime, transferSize are already included. Request count seems like a worthy addition.

Yes, I am willing to implement if there's a positive signal from team LH.

Other possible alternatives*

  • The network-requests audit could be enhanced so that it nominates corresponding LHR entities (3Ps). Then it would be quite ergonomic to collect third party requests for further analysis.
  • LHR entities could be updated to provide some statistics like requestsCount. (I don't think this is a good solution, but sharing it as an idea all the same)

What is the motivation or use case for changing this?

Adding further understanding to the impacts a given third party makes on a page.

How is this beneficial to Lighthouse?

  • Another data point to help describe third party impacts
  • Greater appreciation for potentially problematic third parties
@adamraine
Copy link
Member

adamraine commented May 22, 2023

The network-requests audit could be enhanced so that it nominates corresponding LHR entities (3Ps). Then it would be quite ergonomic to collect third party requests for further analysis.

Adding the 3P entity name to the network requests seems good. Makes it much easier to do a lookup without using new URL().orign.

Related: #14737

@benschwarz
Copy link
Contributor Author

Having slept on it for a few nights, I think updating the network requests audit so that it's the primary source of all-request related attributes is a solid improvement.

Would y'all like me to take a stab at adding third party info to network-requests?

@adamraine
Copy link
Member

Would y'all like me to take a stab at adding third party info to network-requests?

Sure!

@StarSyntaxStatic

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants