Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LCP lantern graphs #15737

Open
adamraine opened this issue Jan 9, 2024 · 0 comments
Open

Improve LCP lantern graphs #15737

adamraine opened this issue Jan 9, 2024 · 0 comments

Comments

@adamraine
Copy link
Member

The general problem we were dealing with was that LCP graphs can be somewhat noisy due to both optimistic and pessimistic graphs casting very wide nets when it comes to network requests.

This can lead to situations where reducing the download time of some unimportant request can "improve" the LCP time because it happened to be the last request to finish in the graph (#15651 (comment)). Conversely, improving the timing of the LCP image record can yield 0 LCP savings if there are many other requests that the LCP graph decides are dependencies for LCP (#15636 (comment))

To resolve this, I think we should redefine our optimistic LCP graph to focus on the LCP critical path. Right now the optimistic graph is extremely similar to the pessimistic graph (only excluding low prio image nodes) so it can be just as noisy. It's also worth noting that if the LCP image record is low priority it will not appear in the optimistic graph despite being the most important record for LCP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant