Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Page.getAppManifest's errors object #1666

Closed
paulirish opened this issue Feb 8, 2017 · 2 comments
Closed

Adopt Page.getAppManifest's errors object #1666

paulirish opened this issue Feb 8, 2017 · 2 comments

Comments

@paulirish
Copy link
Member

paulirish commented Feb 8, 2017

We currently don't listen to any of the errors and warnings that Chrome's native manifest parser spits back. It includes parsing errors (invalid JSON) as well as manifest correctness errors.

There's two levels of adoption really:

  1. Consider the critical errors so we can reject early if Chrome knows it can't read the manifest.
  2. Consider the non-critical errors which overlap with the checks that manifest-parser does

Just #1 probably makes sense for the short term... FWIW here's an example of the sorts of errors we would be getting:

invalid json (critical)

image

bad value for display property (non-critical)

image

bad value for icons property (non-critical)

image


Also see #823 and #1624 where we had some of this discussion

@brendankenny
Copy link
Member

same-ish as #2348, PR up in #2349 (though controversial :)

@adrianaixba
Copy link
Collaborator

As per Chrome’s updated Installability Criteria, Lighthouse will be deprecating the PWA category in the next upcoming release. For future PWA testing, users will be directed to use the updated PWA documentation. Marking this as closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants