Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-level warning for perf-affecting chrome extensions #1689

Closed
ebidel opened this issue Feb 10, 2017 · 3 comments
Closed

Add top-level warning for perf-affecting chrome extensions #1689

ebidel opened this issue Feb 10, 2017 · 3 comments
Labels

Comments

@ebidel
Copy link
Contributor

ebidel commented Feb 10, 2017

Disabled in #1687

Even though the setting was opt-in, the new permission was deemed too risky to add to the crx at this time. It disables Lighthouse and users need to reenable the extension and some extensions do not expect to be shut down like this.

We should create a profile with a bunch of developer extensions and test that this features has measurable impact. If not, we should probably just have banner messaging that suggestions running the extension in a clean profile.

@ebidel
Copy link
Contributor Author

ebidel commented Feb 10, 2017

@patrickhulce also found https://developer.chrome.com/extensions/permissions#manifest (enable permissions at runtime).

@paulirish paulirish changed the title CRX: test the impact of disabling other extensions Add top-level warning for perf-affecting chrome extensions Nov 1, 2017
@paulirish
Copy link
Member

re-scoping this to warn if you have a given extension installed. We'll use a safelist of known bad extensions

@wardpeet
Copy link
Collaborator

wardpeet commented Sep 3, 2019

It has been fixed in #5666. We show a warning when chrome extensions slow down our performance score.

Thank you for opening this issue.

@wardpeet wardpeet closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants