Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node programmatic API #1722

Closed
patrickhulce opened this issue Feb 14, 2017 · 3 comments
Closed

Improve node programmatic API #1722

patrickhulce opened this issue Feb 14, 2017 · 3 comments

Comments

@patrickhulce
Copy link
Collaborator

Brought over from discussion in #1721 (comment).

The example for how to use lighthouse programmatically is quite daunting for someone just getting started. Splitting out the chrome launcher (#1176) would take us pretty far, but also making basic usage possible without having to require specific files deep within the directory structure would be great.

@gauntface
Copy link

I ended up writing a small wrapper for downloading and starting chrome before using the lighthouse node module:

https://github.com/gauntface/gf-site/blob/v3/test/utils/lighthouse-wrapper.js

More than happy to move it out to a node module if it's useful.

@patrickhulce
Copy link
Collaborator Author

Another wrinkle as noted in #1744, the lighthouse results cannot be directly saved as the artifacts have a circular structure

@brendankenny
Copy link
Member

I believe this is mostly complete?

  • chrome-launcher split to own package
  • don't need to require deep files

However, dealing with report/deleting artifacts is still kind of a pain. That part could be merged into the GAR issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants