Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Worker audit needs to test controlling scope #1965

Closed
brendankenny opened this issue Apr 5, 2017 · 2 comments
Closed

Service Worker audit needs to test controlling scope #1965

brendankenny opened this issue Apr 5, 2017 · 2 comments
Labels

Comments

@brendankenny
Copy link
Member

Our current audit only checks for an activated SW on the test page's origin. We need to look specifically at the SW's scope to make sure it can actually control the test page (e.g. by default a service worker at https://example.com/dir/sw.js can only control pages under ./dir/ and can't be the SW for https://example.com/).

Looking at the protocol response, I'm not sure if we'll be able to test the scope directly and so we may need to resort to testing that the target page's TargetID is in controlledClients.

@mutdmour
Copy link

mutdmour commented Oct 27, 2017

Was looking into working on this one. But I have yet to find a service worker in the wild that has any TargetIds in controlledClients. Thoughts? Also, should it be it's own separate audit for meta to return an accurate message of the issue? Or should I try to add some property that controls what the failureDescription is?

@brendankenny
Copy link
Member Author

fixed in #6609 and #6678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants