Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't break back-compat of the LHR #2165

Closed
paulirish opened this issue May 5, 2017 · 1 comment
Closed

Don't break back-compat of the LHR #2165

paulirish opened this issue May 5, 2017 · 1 comment

Comments

@paulirish
Copy link
Member

We'll have people saving lhr.json files more often now. And if they drag one from folder into devtools audits, they'll expect to see a report.

My proposal to make this easier:

  • the LHR gets a .config property which is the actual config.
  • do the generateReportJson()/etc work inside of the generateHTML method
  • optional: we could even expose a more static scoreReport method in case other modules wanted scores/certifications. (Similar public API-ness makes sense for the pw-metrics-events metric gathering_

But to paraphrase pavel, the sooner you start guaranteeing the backcompat of this API the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants