Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to expose an option in lighthouse core to launch chrome? #2259

Closed
samccone opened this issue May 16, 2017 · 3 comments
Closed

Comments

@samccone
Copy link
Contributor

samccone commented May 16, 2017

The common use-case for using lighthouse programmatically is to launch chrome with it.. right now that is a nested promise with a bit of clean up at the end... The reason for most of this work boils down to the need to pass port from the launcher to lighthouse.. because of this I think it might be nice to do something like

flags.launchChrome = true;
return Lighthouse(url, flags, config);

Which would take care of killing and launching chrome.

@wardpeet
Copy link
Collaborator

Fine by
cc @paulirish @ebidel @patrickhulce @brendankenny

@wardpeet wardpeet added the cli label May 23, 2017
@ebidel
Copy link
Contributor

ebidel commented May 23, 2017

I like it. We need to cater better to the common cases like this. One question I have is how we would handle lh flags, flags to the launcher, and chromeFlags Would everything go in flags?

@devtools-bot
Copy link

This issue was moved to GoogleChrome/chrome-launcher#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants