Runs out of memory for complex pages

[pmeenan]

Not sure if it is tied to the video frames or just the size of the trace

(warning, page is NSFW - admin added a space to the link ;) )
lighthouse --verbose --max-wait-for-load 120000 http://www pornolab.net/

....
  statusEnd:verbose Evaluating: First meaningful paint +1s
  status Evaluating: Page load is fast enough on 3G +1ms

<--- Last few GCs --->

[23124:0x28ef6f0]   943131 ms: Mark-sweep 1351.4 (1618.1) -> 1351.0 (1618.1) MB, 1719.3 / 0.0 ms  allocation failure GC in old space requested
[23124:0x28ef6f0]   945188 ms: Mark-sweep 1351.0 (1618.1) -> 1351.0 (1618.1) MB, 1713.6 / 0.0 ms  allocation failure GC in old space requested
[23124:0x28ef6f0]   947446 ms: Mark-sweep 1351.0 (1618.1) -> 1351.0 (1601.6) MB, 1912.8 / 0.0 ms  last resort 
[23124:0x28ef6f0]   949549 ms: Mark-sweep 1351.0 (1601.6) -> 1351.0 (1586.6) MB, 2102.7 / 0.0 ms  last resort 


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3b1ed34a66a1 <JS Object>
    1: add [native collection.js:~113] [pc=0x237126ad5b4e](this=0x946dc871579 <a Set with map 0x3d2239805329>,q=0x26317d4759f9 <a ThreadSlice with map 0x9de25699d81>)
    2: push [/usr/lib/node_modules/lighthouse/lighthouse-core/third_party/traceviewer-js/model/event_set.js:~1] [pc=0x237126c30940](this=0x946dc8705f9 <an EventSet with map 0x3320cc3fce89>,event=0x26317d4759f9 <a ThreadSlice with ...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x134e91c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::OrderedHashTable<v8::internal::OrderedHashSet, v8::internal::JSSetIterator, 1>::Allocate(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::OrderedHashTable<v8::internal::OrderedHashSet, v8::internal::JSSetIterator, 1>::Rehash(v8::internal::Handle<v8::internal::OrderedHashSet>, int) [node]
 8: v8::internal::OrderedHashTable<v8::internal::OrderedHashSet, v8::internal::JSSetIterator, 1>::EnsureGrowable(v8::internal::Handle<v8::internal::OrderedHashSet>) [node]
 9: v8::internal::Runtime_SetGrow(int, v8::internal::Object**, v8::internal::Isolate*) [node]
10: 0x2371262043a7
Aborted (core dumped)

[patrickhulce]

I've had this happen a few times as well when doing plots runs. Locally I've just increased the node old space size with --max_old_space_size=4096, but it'd be nice to nix this. Hopefully #2347 will help.

[patrickhulce]

This might be fixed by removing traceviewer and streaming JSON parsing.

[paulirish]

Thanks for filing. Plz file again if this comes back up.