Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: non-applicable audits #2690

Closed
joeyparrish opened this issue Jul 14, 2017 · 4 comments
Closed

Feature request: non-applicable audits #2690

joeyparrish opened this issue Jul 14, 2017 · 4 comments

Comments

@joeyparrish
Copy link

I would like to be able to write an audit which can be skipped in the report. For example, I'm auditing JS libraries and looking for things that can be upgraded. If those libraries are not used, it would be nice to be able to return a result with something like skip: true in it. That audit would then not show up in the report.

Is there some way to do this today? Would it be trivial to add a flag for this? Is there another way I should be thinking about this problem?

CC: @hbengali

@paulirish paulirish changed the title Feature request: skipped audits Feature request: non-applicable audits Oct 12, 2017
@patrickhulce
Copy link
Collaborator

Great idea @joeyparrish! We'll need to do some thinking about the appropriate UX here.

cc: @vinamratasingal

@joeyparrish
Copy link
Author

Thanks!

@paulirish
Copy link
Member

Idea: in addition to adding a nonApplicable flag to auditResults, I'm thinking we should provide a text nonApplicableReason so each can explain why. e.g. "No forms found on the page", etc.

@vinamratasingal-zz
Copy link

Closing in favor of the umbrella issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants