Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrome-launcher: add support for pollInterval or pollRetries as an option #3110

Closed
alekseykulikov opened this issue Aug 24, 2017 · 1 comment
Closed

chrome-launcher: add support for pollInterval or pollRetries as an option #3110

alekseykulikov opened this issue Aug 24, 2017 · 1 comment
Labels
feature good first issue

Comments

@alekseykulikov
Copy link
Contributor

Currently pollInterval = 500 ms and pollRetries = 10 are hard-coded. It means, that launcher waits approximately 5s and then fails.
Sometimes, this is time not enough to start a Chrome, especially on slow machines or first boot inside new env.
I'd like to provide a PR, but first I'd like to hear feedback, should it be only pollRetries or both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paulirish @alekseykulikov @patrickhulce @devtools-bot