Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove audit.meta.category #3252

Closed
paulirish opened this issue Sep 5, 2017 · 4 comments
Closed

Remove audit.meta.category #3252

paulirish opened this issue Sep 5, 2017 · 4 comments

Comments

@paulirish
Copy link
Member

As discussed here #3227 (comment) .. it's not needed and we can drop it.

@arturmiz
Copy link
Contributor

arturmiz commented Oct 10, 2017

I can take a look on this one and do the cleanup :)

@Siilwyn
Copy link

Siilwyn commented Oct 19, 2017

@arturmiz hi I'm using the audit category in my own parser, maybe I should switch to only using what's under the reportCategories key...

But for now, how should I get the associated category given an audit now? Any ideas appreciated. =)

@patrickhulce
Copy link
Collaborator

@Siilwyn yes you should use the category it's associated with in reportCategories, the audit.meta.category was not the real "category" you see in the report and was a somewhat irrelevant and old display string :) sorry for the churn!

@Siilwyn
Copy link

Siilwyn commented Oct 19, 2017

@patrickhulce thank you for your reply! I already found it odd that it used different names, so I wrote a mapping function to convert them to the correct category. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants