Resolve audit result values

[paulirish]

Currently...

• result.value - most of the time is actually === a score
• result.rawValue - many times its a string of "1232.32ms" .. not exactly "raw"

Proposal

• result.score
• result.rawValue - which is either a number or boolean, never a string
• result.displayValue - which is a string

[brendankenny]

LGTM

[paullewis]

LGTM

[wardpeet]

I'm working on this ticket as we speak but what should happen with rawValue when it's a color? should it just say true?
What with score false? Should it convert to 0 and have a rawValue of false and displayValue of ''?

Is the only required value a score? (like it's now with value)

--edit

Perhaps it's best to convert score to a number (false will be 0, true will be 100) or maybe this should only be filled in when you have a score.
rawValue will be always filled in (it's the same as the previous value but than always raw) and displayValue will convert rawValue to a string with perhaps extra data.

Sounds good?

[paulirish]

I'm working on this ticket as we speak but what should happen with rawValue when it's a color? should it just say true?

Theme-color? TBH it's kinda superfluous that we report it. The rawValue there should be boolean. Can move the color into extendedInfo

What with score false? Should it convert to 0 and have a rawValue of false and displayValue of ''?

shrug...

[wardpeet]

I'll just prepare a pr and i'll just wait for feedback :p

[wardpeet]

Fixing some bugs, almost done so will have a pr ready today or tomorrow

[paulirish]

awesome! thanks for the update man