Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixed-content fix and smoke tests #5498

Closed
2 tasks
brendankenny opened this issue Jun 14, 2018 · 2 comments · Fixed by #10159
Closed
2 tasks

mixed-content fix and smoke tests #5498

brendankenny opened this issue Jun 14, 2018 · 2 comments · Fixed by #10159
Labels
P1.5

Comments

@brendankenny
Copy link
Member

Discovered by @patrickhulce in #5451 (comment)

  • request interception is currently broken for us, so the gatherer doesn't really work at all
  • needs a smoke test to alert us to future breakage
@paulirish
Copy link
Member

confirmed broken on example.com

@connorjclark
Copy link
Collaborator

This is working today.

node lighthouse-cli https://googlesamples.github.io/web-fundamentals/fundamentals/security/prevent-mixed-content/active-mixed-content.html  --preset=mixed-content --view

Still no smoke test.

@connorjclark connorjclark mentioned this issue Dec 30, 2019
Merged
@brendankenny brendankenny mentioned this issue Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests(smokehouse): mixed-content GoogleChrome/lighthouse
3 participants
@paulirish @brendankenny @connorjclark