Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only capture similar exceptions in sentry once per audit #5994

Closed
1 of 6 tasks
brendankenny opened this issue Sep 7, 2018 · 0 comments · Fixed by #6215
Closed
1 of 6 tasks

Only capture similar exceptions in sentry once per audit #5994

brendankenny opened this issue Sep 7, 2018 · 0 comments · Fixed by #6215

Comments

@brendankenny
Copy link
Member

brendankenny commented Sep 7, 2018

Discussed in #5993. We're lowering the overall sample rate, but to get an idea of relative error rates, we need to stop capturing a bunch of exceptions per audit. e.g. if multiple offscreen images have issues with their sizing information, we capture an exception per image.

Instead we should capture a single exception for the whole audit, noting the issue and giving enough information that the specific problem image can be tracked down (e.g. maybe just log the first one, which gets you details, not just that there was a problem in general).

Places to fix:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant