Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report details table right-alignment is ugly #6049

Closed
paulirish opened this issue Sep 18, 2018 · 3 comments
Closed

report details table right-alignment is ugly #6049

paulirish opened this issue Sep 18, 2018 · 3 comments
Assignees
@wardpeet
Labels
P1

Comments

@paulirish
Copy link
Member

paulirish commented Sep 18, 2018 •
edited
Loading

e.g.
image

first column should always be left aligned.

but ideally all text columns are left-aligned and all number columns are right-aligned. not sure if we have the classes for this, but we might.

shane sez we should drop the centered TH's too. let's keep them always the same as the TDs
@paulirish paulirish added the P1 label Sep 18, 2018
@exterkamp exterkamp mentioned this issue Sep 18, 2018
Closed
@wardpeet
Copy link
Collaborator

wardpeet commented Sep 19, 2018 •
edited
Loading

what do we assign as a number?
we currently have these types:

  • .lh-table-column--text
  • .lh-table-column--bytes
  • .lh-table-column--timespanMs
  • .lh-table-column--ms
  • .lh-table-column--url
  • .lh-table-column--node

I guess we align everything right except the checked items in the list
we end up with
image

@wardpeet wardpeet mentioned this issue Sep 19, 2018
Merged
@exterkamp exterkamp mentioned this issue Sep 19, 2018
Merged
@brendankenny
Copy link
Member

fixed? or 3/6 fixed

@wardpeet
Copy link
Collaborator

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wardpeet wardpeet

Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulirish @brendankenny @wardpeet