Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly emulate desktop in headless scenarios #6092

Closed
paulirish opened this issue Sep 22, 2018 · 2 comments · Fixed by #6098
Closed

Correctly emulate desktop in headless scenarios #6092

paulirish opened this issue Sep 22, 2018 · 2 comments · Fixed by #6098
Assignees
Labels

Comments

@paulirish
Copy link
Member

When we're run in headless (LR) and we want the desktop experience, the viewport behavior is quite undefined, leading to screenshots that are cut off:
image

We think desktop "emulation" is the answer here. I've tried it out and everything looks more expected in headless:
image

TBH our driver & emulation code don't nicely account for this scenario, so it'll need some thought. @patrickhulce this seems up your alley. watcha thinkin?

@patrickhulce
Copy link
Collaborator

yeah I've been chewing on this idea too after #5893, I'm thinking an enum for formFactor or some such name instead of disableMobileEmulation :)

@paulirish
Copy link
Member Author

I'm thinking an enum for formFactor or some such name instead of disableMobileEmulation

that sounds great. disableMobileEmulation is an OK cli flag, but it's proven to be quite cumbersome in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants