Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Project related with lighthouse] - Lighthouse github reporter #6097

Closed
carlesnunez opened this issue Sep 24, 2018 · 4 comments
Closed

[Project related with lighthouse] - Lighthouse github reporter #6097

carlesnunez opened this issue Sep 24, 2018 · 4 comments
Labels
needs-priority

Comments

@carlesnunez
Copy link
Contributor

Hello everyone!

In order to improve my own software development pipe I decided to create an small tool that let us launch a lighthouse benchmark and with an small config by package.json or cli we can setup that this report end up on a comment on the PR that we decide:
https://www.npmjs.com/package/lighthouse-gh-reporter
https://github.com/carlesnunez/lighthouse-github-reporter

I'll be so happy if it gets added on the base lighthouse readme :)

Star if it helped you, this is on a really early stage and can be code improved so... I am really opened to PR's and improvements.

Hope it helps you as it helped me!!
@wardpeet
Copy link
Collaborator

@carlesnunez could you make the change yourself an shoot a PR for it?

@carlesnunez
Copy link
Contributor Author

Off course! I’ll do it today or tomorrow :)

@carlesnunez carlesnunez mentioned this issue Oct 17, 2018
Merged
@carlesnunez
Copy link
Contributor Author

Done! @wardpeet

@exterkamp
Copy link
Member

This was fixed when #6307 merged. Congrats on the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paulirish @wardpeet @carlesnunez @exterkamp