Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: produce LHR when error is thrown during gather-runner #6330

Closed
connorjclark opened this issue Oct 17, 2018 · 3 comments
Closed

core: produce LHR when error is thrown during gather-runner #6330

connorjclark opened this issue Oct 17, 2018 · 3 comments

Comments

@connorjclark
Copy link
Collaborator

requires non trivial refactoring of gather-runner#run

Non-CLI entry points handle errors being thrown adequately, but the CLI simply prints the error without creating a LHR. @paulirish would like to see errors handled more gracefully. @brendankenny has opinions, too.

Opening this ticket to track any conversation for/against.

Relates to #6300

@brendankenny
Copy link
Member

I don't mind gracefully handling errors, but we have showRuntimeError() for that in the CLI :) (and equivalents in the extension and devtools)

I think it's a different situation than in LR where we always need something that fits something like the LHR shape, including in the cases of complete errors. For the other clients I'd rather have a nice message telling me the error (with am exit code for the CLI) rather than getting an empty report with a big error box at the top.

@exterkamp
Copy link
Member

Is this decided now with #6671 and #6739

@connorjclark
Copy link
Collaborator Author

yesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants