Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark Index can cause a proto unmarshalling error. #6331

Closed
exterkamp opened this issue Oct 17, 2018 · 1 comment · Fixed by #6332
Closed

Benchmark Index can cause a proto unmarshalling error. #6331

exterkamp opened this issue Oct 17, 2018 · 1 comment · Fixed by #6332
Assignees
@exterkamp

Comments

@exterkamp
Copy link
Member

What is the current behavior?

Convert JSON -> proto with a non integer benchmark_index e.g. 502.485 results in a conversion error.
@exterkamp exterkamp self-assigned this Oct 17, 2018
@exterkamp exterkamp mentioned this issue Oct 17, 2018
Merged
@exterkamp
Copy link
Member Author

Also rtt_ms max_wait_for_load cpu_slowdown_multiplier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exterkamp exterkamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

misc(proto): convert int32's into DoubleValue in proto GoogleChrome/lighthouse
1 participant
@exterkamp