Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent style for lh-warnings #7011

Closed
exterkamp opened this issue Jan 14, 2019 · 3 comments · Fixed by #9271
Closed

Consistent style for lh-warnings #7011

exterkamp opened this issue Jan 14, 2019 · 3 comments · Fixed by #9271

Comments

@exterkamp
Copy link
Member

Mentioned in #6989. I think the lh-warnings style looks out of place with the report style e.g.
image

My suggestion is to replace the 1px border with a light orange background (#fff5e3):
image

Would love some thoughts. @hwikyounglee

@paulirish
Copy link
Member

@yuinchien is looking at this.

@hwikyounglee
Copy link

Su^per late -

@exterkamp 's suggestion on using the bg color instead of border looks good to me while we're currently looking at a longer term approach in a separate effort.

@exterkamp
Copy link
Member Author

I'm gonna give this to @hoten as part of the report-redesign 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants