Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement android chrome launcher #910

Closed
samccone opened this issue Nov 5, 2016 · 2 comments
Closed

Implement android chrome launcher #910

samccone opened this issue Nov 5, 2016 · 2 comments
Assignees

Comments

@samccone
Copy link
Contributor

samccone commented Nov 5, 2016

Running lighthouse currently on an android phone is pretty tedious.

Ideally a user should be able to run lighthouse and pick a connected android phone to run chrome on and run the selected audits.

Implementations steps.

  1. detect if adb is in the path or set via ADB_PATH
  2. adb devices -l to get the connected devices
  3. present the list of devices to pick from
  4. detect is chrome canary installed, if not bail.
  5. launch chrome canary on the device
  6. setup port forwarding from device
    adb forward tcp:9222 localabstract:chrome_devtools_remote
  7. run lighthouse 💃
@samccone samccone self-assigned this Nov 5, 2016
@paulirish
Copy link
Member

I think we could exclude support for multiple devices for the moment. I personally get nervous to have multiple devices connected over adb and trust that the right commands will go to the right phone, so I always unplug the one i'm not working with. But if you'd rather keep it in scope, then sure. :)

How do you want to handle getting a clean baseline? Clean chrome profile? Can we do user-data-dir via flag on android? Do we only use Canary and say "We'll be wiping your storage and SWs, FYI!"?

@paulirish
Copy link
Member

moved to GoogleChrome/chrome-launcher#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants