Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️ 👣 Breaking changes for v6 #9180

Closed
2 tasks
patrickhulce opened this issue Jun 11, 2019 · 7 comments
Closed
2 tasks

☂️ 👣 Breaking changes for v6 #9180

patrickhulce opened this issue Jun 11, 2019 · 7 comments
Labels
chillin ❄

Comments

@patrickhulce
Copy link
Collaborator

patrickhulce commented Jun 11, 2019 •
edited by brendankenny
Loading

Summary

No time like the present to get started on our next breaking changes list :)

  • Remove path support for --extra-headers (and possibly budget-path?) as now users can use cli-flags-path

Possibly:
@patrickhulce patrickhulce mentioned this issue Jun 11, 2019
Closed
@exterkamp
Copy link
Member

exterkamp commented Jun 12, 2019 •
edited by brendankenny
Loading

Proto idea: refactor i18n section in proto to use Map<string, string> instead of RendererFormattedStrings

@brendankenny brendankenny mentioned this issue Jul 23, 2019
Closed
@exterkamp
Copy link
Member

Why is benchmark_index a DoubleValue in proto when it isn't nullable in ts?

@connorjclark
Copy link
Collaborator

Why is benchmark_index a DoubleValue in proto when it isn't nullable in ts?

image

#6332

:)

@patrickhulce
Copy link
Collaborator Author

That PR is confusing to me, it seems like the conversation all agreed it should be an int but we merged the change to double...?

@connorjclark
Copy link
Collaborator

lol yeah why did we round it and also double it ...

@exterkamp
Copy link
Member

Hm, that is weird 😕 😕

@brendankenny brendankenny mentioned this issue Oct 2, 2019
Closed
54 tasks
@brendankenny
Copy link
Member

this didn't get long (we probably have forgotten some stuff :), so closing in favor of #9774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chillin ❄
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brendankenny @patrickhulce @connorjclark @exterkamp