Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse Extension Error #966

Closed
skylerto opened this issue Nov 18, 2016 · 11 comments · Fixed by #999
Closed

Lighthouse Extension Error #966

skylerto opened this issue Nov 18, 2016 · 11 comments · Fixed by #999

Comments

@skylerto
Copy link

Lighthouse Version: 1.2.0
Chrome Version: 56.0.2924.0
Error Message: {"code":-32000,"message":"Result of the evaluation is not a promise"}
Stack Trace:
undefined

@wardpeet wardpeet self-assigned this Nov 18, 2016
@wardpeet
Copy link
Collaborator

wardpeet commented Nov 18, 2016

can we get a url as well to test on, can not reproduce it at the moment with perhaps some options that you are using/not using

@skylerto
Copy link
Author

I wish i could but the site is hosted locally, currently developing it.

@brendankenny
Copy link
Member

if you can easily reproduce this, a copy of the lighthouse log near there would be really useful.

You can access by going to about:extensions, clicking the "Inspect views: background page" link under lighthouse to open up DevTools, going to the console panel, then running the Lighthouse extension as you were.

There should be some 'method => browser' and method <= browser ERR messages before the error happens. The exact method being run and the parameters used should be in those messages.

@a-xin
Copy link

a-xin commented Nov 19, 2016

I'm also seeing this issue on a private page, that's the error log I get in "Inspect views" on Chrome Version 54.0.2840.100 (64-bit), Ubuntu 16.10, lighthouse 1.2.0

[...]
status Retrieving: EventListeners +201ms     lighthouse-background.js:62169
<= DOM.setChildNodes +5ms Object       lighthouse-background.js:62169
[...]
<= DOM.setChildNodes +0ms Object
status Retrieving: AnchorsWithNoRelNoopener +133ms
status Retrieving: AppCacheManifest +7ms
status Retrieving: ConsoleTimeUsage +7ms
method <= browser ERR:error Runtime.evaluate +2ms 
status Retrieving: DateNowUse +1ms
method <= browser ERR:error Runtime.evaluate +1ms 
status Retrieving: DocWriteUse +1ms
method <= browser ERR:error Runtime.evaluate +3ms 
status Retrieving: GeolocationOnStart +2ms
method <= browser ERR:error Runtime.evaluate +2ms 
status Disconnecting from browser... +1ms

Object
message: "{"code":-32000,"message":"Result of the evaluation is not a promise"}"
__proto__: Object
background.loadSelectedAggregations.then.then.catch.err @ scripts/popup.js:184

@skylerto
Copy link
Author

👍 same log

@ebidel
Copy link
Contributor

ebidel commented Nov 20, 2016

Looks like an error in the protocol, probably from evaluateAsync. #977 and #976 might give us better insight.

@brendankenny
Copy link
Member

brendankenny commented Nov 20, 2016

so I noticed this yesterday: geolocation-on-start is the only gatherer using evaluateAsync that doesn't catch driver errors from it. Should be an easy fix just for this particular error, though that won't fix the artifact produced.

What's really interesting about this log though is that every evaluateAsync call is failing (the error is caught by every gatherer but geolocation, though). With this particular fix the lighthouse run will complete, but all the results will be -1. No idea how that could be happening at this point.

@wardpeet wardpeet removed their assignment Nov 21, 2016
@wardpeet
Copy link
Collaborator

I can not seem to reproduce this.

@a-xin
Copy link

a-xin commented Nov 21, 2016

@wardpeet Just realized I can reliably reproduce it on this demo project. Can you reproduce the issue there?

@wardpeet
Copy link
Collaborator

wardpeet commented Nov 21, 2016

yes I can.
I think @brendankenny is fixing this in #977
@brendankenny if not I can take this one.

@brendankenny
Copy link
Member

I opened #1000 to figure out the larger issue of why some sites fail all evaluateAsync calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants