Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images in the docs #9841

Closed
chrisdeveloperit opened this issue Oct 14, 2019 · 4 comments
Closed

Update images in the docs #9841

chrisdeveloperit opened this issue Oct 14, 2019 · 4 comments

Comments

@chrisdeveloperit
Copy link

chrisdeveloperit commented Oct 14, 2019

A PWA score does not display, even though 9/11 items under Progressive Web App tests are positive. Scores display for all other tests.
[MDEV-Property-VideoIntro.pdf]
(pdf removed)

@patrickhulce
Copy link
Collaborator

@chrisdeveloperit the PWA category has sections to complete that represent the different aspects of being a PWA, the numeric score is not really meaningful and is never displayed to the user. Upon completion of all 11 items it changes to a checkmark.

image

@chrisdeveloperit
Copy link
Author

Thank you @patrickhulce . The Lighthouse Scoring Guide lead our team to think that our Lighthouse Report should look like the image displayed in their documentation. https://developers.google.com/web/tools/lighthouse/v3/scoring
LighthouseUI

@patrickhulce
Copy link
Collaborator

Ah thanks for the explanation @chrisdeveloperit! That is the scoring guide for v3 which used a numeric system for PWA. From v4 onward (on v5.5.0 currently), the PWA scoring system is the one you see in the pdf you filed 👍

@connorjclark connorjclark changed the title PWA Score not displaying Update images in the docs Jan 6, 2020
@connorjclark
Copy link
Collaborator

We should update all these stale images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants