This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
use last tab if multiple tabs found #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulirish
commented
Feb 10, 2016
paulirish
commented
|
the rethrown error fixes the swallowed errors. |
| @@ -94,6 +95,8 @@ try { | |||
| strict: argv.strict | |||
| }); | |||
| }); | |||
|
|
|||
| throw e; | |||
There was a problem hiding this comment.
If you always throw e we always exit with an error, right? I wonder if a better way is to only swallow if the error occurs because of the fs.stat call. Other than that we probably want to throw it.
|
Also tests fail. I guess the multi process one! |
|
Actually, that test is todoooooo: https://github.com/GoogleChrome/node-big-rig/blob/master/test/bigrig_tests.js#L52 Well done me. |
paullewis
added a commit
that referenced
this pull request
Feb 10, 2016
use last tab if multiple tabs found
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.