This repository has been archived by the owner on Jan 21, 2021. It is now read-only.
Add filesBlacklist to avoid preloading certain files
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@jackfranklin Implementation LGTM. Could you add a commit with some README content? Thanks for the PR! |
|
@jackfranklin Fyi, we just merged a change that will require a rebase against master. Hope you're still interested in landing this :) |
jackfranklin
force-pushed
the
add-files-blacklist
branch
from
4668af0
to
ead0b85
Compare
For example, sourcemaps should not be preloaded. This is configurable via the `filesBlacklist` option. This would be a breaking change, but you could easily avoid that by making the array empty and just advising people on how to add it in the docs.
jackfranklin
force-pushed
the
add-files-blacklist
branch
from
ead0b85
to
89450d8
Compare
|
@addyosmani rebased and tests updated - definitely up for this to land! Just writing README. |
|
👍 |
|
@jackfranklin thanks for the feature @addyosmani any chance you could release a version for this new feature? I would like to use that in my project. Thanks in advanced! |
|
@laysent done! new version out :) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, sourcemaps should not be preloaded.
This is configurable via the
filesBlacklistoption. This would be abreaking change, but you could easily avoid that by making the array
empty and just advising people on how to add it in the docs.
@addyosmani I needed this so I could use this in a project - thought I might as well make the PR. I'm happy to work on the README and stuff if you do want something like this in the project - else no problem!