Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page.goto is littered with races #1218

Closed
aslushnikov opened this issue Oct 31, 2017 · 0 comments
Closed

page.goto is littered with races #1218

aslushnikov opened this issue Oct 31, 2017 · 0 comments
Assignees
@aslushnikov
Labels
P1

Comments

@aslushnikov
Copy link
Contributor

Since the migration to lifecycle events (ce8a952), the page.goto, page.waitForNavigation and other navigation methods are terribly flaky.

We're fighting it upstream. This should be fixed before releasing next PPTR version.
@aslushnikov aslushnikov self-assigned this Oct 31, 2017
@aslushnikov aslushnikov added the P1 label Oct 31, 2017
This was referenced Oct 31, 2017
Closed
Closed
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Nov 10, 2017
@aslushnikov
feat(Chromium): roll chromium to r515411
f42868e 
This roll includes the following revisions:
- crrev.com/515281 DevTools: fix crash on intercepting request that
  posts a blob
- crrev.com/515368 DevTools: wait for navigation to be committed
  upon Page.navigate on the browser side.

Fixes puppeteer#894, References puppeteer#1218
@aslushnikov aslushnikov mentioned this issue Nov 10, 2017
Merged
aslushnikov added a commit that referenced this issue Nov 10, 2017
@aslushnikov
feat(Chromium): roll chromium to r515411 (#1346)
9c1935b 
This roll includes the following revisions:
- crrev.com/515281 DevTools: fix crash on intercepting request that
  posts a blob
- crrev.com/515368 DevTools: wait for navigation to be committed
  upon Page.navigate on the browser side.

Fixes #894, References #1218
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Nov 10, 2017
@aslushnikov
fix(Navigation): correctly wait for navigation in Page.goto
40bd03c 
This patch:
- starts persisting lifecycle state for every frame
- migrates NavigationWatcher to rely on these lifecycle events
- refactors Page.goto to properly return navigation errors

Fixes puppeteer#1218.
@aslushnikov aslushnikov mentioned this issue Nov 10, 2017
Merged
aslushnikov added a commit that referenced this issue Nov 10, 2017
@aslushnikov
fix(Navigation): correctly wait for navigation in Page.goto (#1355)
44d1e83 
This patch:
- starts persisting lifecycle state for every frame
- migrates NavigationWatcher to rely on these lifecycle events
- refactors Page.goto to properly return navigation errors

Fixes #1218.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aslushnikov