Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for <video> elements with mp4 files / use of proprietary codecs #381

Closed
joakimgrr opened this issue Aug 18, 2017 · 6 comments
Closed

Comments

@joakimgrr
Copy link

Pardon my possible ignorance on the matter, just discovered this today. As far as I know, chromium doesn't support mp4 out of the box. So a embedded

My question is, are those proprietary codecs already included in the chromium executable that puppeteer uses and if not, can they be added somehow?

@Garbee
Copy link
Contributor

Garbee commented Aug 18, 2017

Only in Chrome. Which if you're using that we recommend Canary currently as Puppeteer relies on new modifications landing now. Which aren't in Beta/Stable channel builds yet.

Ref #291

@joakimgrr
Copy link
Author

@Garbee Ah, tried going trough the issues before writing one, but didn't notice that one. Thank you for your fast response!

Apparently Canary is not available on linux (i would be running this in a Ubuntu Docker container). What would be the best approach in this situation? Dev / beta release channel of chrome perhaps?

@Garbee
Copy link
Contributor

Garbee commented Aug 18, 2017

Canary -> Dev -> Beta -> Stable

So Dev is the best bet but things still may be quirky right now.

Beyond that, there is nothing you really can do. It's a codec problem and unless the MPEG group allows open and free re-use, Chromium can't include it.

@joakimgrr
Copy link
Author

Totally understandable. I'll go with the dev route and hopefully get good enough results! Thank you!

@ebidel
Copy link
Contributor

ebidel commented Aug 18, 2017

Marking this as resolved, but we'll keep it open for a bit so users can find it.

@pavelfeldman
Copy link
Contributor

So you need to wait for fresh enough chrome to get to the Dev (takes a week or so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants