Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browser.closed and page.closed events #952

Closed
aslushnikov opened this issue Oct 4, 2017 · 5 comments · Fixed by #960
Closed

Add browser.closed and page.closed events #952

aslushnikov opened this issue Oct 4, 2017 · 5 comments · Fixed by #960
Labels
feature

Comments

@aslushnikov
Copy link
Contributor

  • Fire browser.closed event when the underlying browser process gets closed / crashes
  • Fire page.closed event when the page gets closed / crashes

This will help to build reliable scripts that restart browser or reopen pages when they crash.
This was referenced Oct 4, 2017
Closed
Closed
Closed
@sukrosono
Copy link
Contributor

currently no PR to this right? Is it ok if i just take page.closed ?

@sukrosono sukrosono mentioned this issue Oct 5, 2017
Merged
2 tasks
@sukrosono
Copy link
Contributor

sukrosono commented Oct 14, 2017 •
edited

Hi @aslushnikov , please correct me if i am wrong. With

Fire browser.closed event when the underlying browser process gets closed / crashes

My attempt was to close the browser when the page got crashed. But the result was 370 specs, 309 failures, This is what my attempt looks like. Here the travis build failure, and the raw log (too many error so the summary only available on raw log). Gladly awaiting your response 😄 .

update
Sorry to brother you i just found Browser.close via #1027. I will try use that, even i don't know the impact yet. When you have free time, please give me some direction, a couple of word help me alot.

@aslushnikov aslushnikov mentioned this issue Oct 31, 2017
Closed
aslushnikov pushed a commit that referenced this issue Nov 4, 2017
@sukrosono @aslushnikov
feat(browser): add browser.disconnected event (#960)
03fefb5 
This patch adds a 'disconnected' event for the browser. The event is issued
when the "browser" loses connection to the chrome process.

References #952
@aslushnikov
Copy link
Contributor Author

For this to be closed, the 'page.disconnected' is also necessary.

@aslushnikov aslushnikov reopened this Nov 4, 2017
aslushnikov pushed a commit that referenced this issue Mar 28, 2018
@JoelEinbinder @aslushnikov
feat(Page): page 'close' event (#2232)
d46e157 
This patch adds 'page.close' event.

References #952.
@aslushnikov
Copy link
Contributor Author

We now have browser.disconnected and page.close events.

@natsu90
Copy link

natsu90 commented Aug 27, 2023

is there anyway i can know either the browser is crashed or closed from the disconnected event? i only want to relaunch the browser when it crashes, not when i called browser.close()

@allburov allburov mentioned this issue Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(browser): add browser.disconnected event
3 participants
@aslushnikov @natsu90 @sukrosono