fix: support PlzNavigate in puppeteer. #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/NetworkManager.js
Outdated
| @@ -179,30 +181,39 @@ class NetworkManager extends EventEmitter { | |||
| } | |||
|
|
|||
| /** | |||
| * @param {string} requestId | |||
| * @param {?string} requestId | |||
| * @param {string} interceptionId | |||
JoelEinbinder
approved these changes
Nov 1, 2017
This patch migrates puppeteer to support PlzNavigate chromium project. As a consequence of this patch, we no longer wait for both requestWillBeSent and requestIntercepted events to happen. This should resolve a ton of request interception bugs that "hanged" the loading. Fixes puppeteer#877.
aslushnikov
force-pushed
the
plznavigate
branch
from
84d002b
to
f3a513d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch migrates puppeteer to support PlzNavigate chromium
project.
As a consequence of this patch, we no longer wait for both
requestWillBeSentandrequestInterceptedevents to happen. This shouldresolve a ton of request interception bugs that "hanged" the loading.
Fixes #877.