chore: remove search.js example #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example is violating the TOS of google.com Fix puppeteer#1557
JoelEinbinder
approved these changes
Dec 9, 2017
|
LGTM. I was thinking we'd just replace the demo with something similar that shows grabbing page content. This example is also nice b/c it shows a couple of the APIs together (keyboard input and click). |
ebidel
approved these changes
Dec 9, 2017
|
@ebidel yeah we'll probably make another one with our own protocol viewer |
|
What about DuckDuckGo? |
|
https://chromedevtools.github.io/devtools-protocol/ is the protocol viewer @aslushnikov is referring to. I think it's probably safer to use that for an example than a site that our team does not maintain. It has an input with search results...so it would be very similar to the original demo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example is violating the TOS of google.com
Fix #1557