fix(Page): support anchor navigation #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes puppeteer navigation primitives to work with same-document navigation. Same-document navigation happens when document's URL is changed, but document instance is not re-created. Some common scenarios for same-document navigation are: - History API - anchor navigation With this patch: - pptr starts dispatching `framenavigated` event when frame's URL gets changed due to same-document navigation - `page.waitForNavigation` now works with same-document navigation - `page.goBack()` and `page.goForward()` are handled correctly. Fixes puppeteer#257.
lib/NavigatorWatcher.js
Outdated
| this._eventListeners = [ | ||
| helper.addEventListener(this._frameManager, FrameManager.Events.LifecycleEvent, this._checkLifecycleComplete.bind(this)), | ||
| helper.addEventListener(this._frameManager, FrameManager.Events.FrameNavigatedWithinDocument, this._navigatedWithingDocument.bind(this)), |
JoelEinbinder
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes puppeteer navigation primitives to work with
same-document navigation.
In browser world, same-document navigation happens when document's URL is changed,
but document instance is not re-created. Some common scenarios
for same-document navigation are:
With this patch:
framenavigatedevent when frame's URL getschanged due to same-document navigation
page.waitForNavigationnow works with same-document navigationpage.goBack()andpage.goForward()are handled correctly.Fixes #257.