Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chromium): roll Chromium to r590951 #3236

Merged
merged 1 commit into from Sep 13, 2018
Merged

feat(chromium): roll Chromium to r590951 #3236

merged 1 commit into from Sep 13, 2018

Conversation

aslushnikov
Copy link
Contributor

Just a healthy roll.

JoelEinbinder
JoelEinbinder suggested changes Sep 13, 2018
View reviewed changes
Copy link
Collaborator

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worker behavior is different in this release. We should be a bit careful

@aslushnikov
Copy link
Contributor Author

@JoelEinbinder in what release and what's different?

@aslushnikov
Copy link
Contributor Author

For the record (as per discussion with @JoelEinbinder):

@dgozman made workers not interrupt JavaScript on runtime evaluate; we might be able to remove some worker hacks.

Waiting for Joel to validate that our workers are reliable enough to roll this.

JoelEinbinder
JoelEinbinder approved these changes Sep 13, 2018
View reviewed changes
Copy link
Collaborator

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aslushnikov aslushnikov merged commit a582acd into puppeteer:master Sep 13, 2018
@aslushnikov aslushnikov deleted the roll-r590951 branch November 2, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Assignees

@JoelEinbinder JoelEinbinder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aslushnikov @JoelEinbinder