feat(chromium): roll Chromium to r648643 #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/page.spec.js
Outdated
| await page.goto(server.EMPTY_PAGE); | ||
| const [message] = await Promise.all([ | ||
| waitEvent(page, 'console'), | ||
| page.setContent(`<script>fetch('http://wat');</script>`), | ||
| ]); | ||
| expect(message.text()).toContain(`ERR_NAME_NOT_RESOLVED`); | ||
| expect(message.text()).toContain(`CORS`); |
There was a problem hiding this comment.
Does this still go through the log domain?
There was a problem hiding this comment.
yeah that's still the case
JoelEinbinder
approved these changes
Apr 8, 2019
This roll includes: - https://crrev.com/648335 - [DevTools] Send DevTools request ID through URLLoader - https://crrev.com/648360 - [DevTools] Add renderer request ID to requestIntercepted References puppeteer#3471
aslushnikov
force-pushed
the
roll-r648643
branch
from
54b1773
to
e7dec98
Compare
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This roll includes:
[DevTools] Send DevTools request ID through URLLoader
[DevTools] Add renderer request ID to requestIntercepted
References #3471