Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: add listen for custom event on page load #529

Merged
merged 2 commits into from Aug 25, 2017
Merged

Example: add listen for custom event on page load #529

merged 2 commits into from Aug 25, 2017

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented Aug 24, 2017

No description provided.

@vsemozhetbyt
Copy link
Contributor

Is missing 'use strict'; intended in all the examples?

vsemozhetbyt
vsemozhetbyt reviewed Aug 24, 2017
View reviewed changes
examples/custom-event.js Outdated
* limitations under the License.
*/

const puppeteer = require('../index.js');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require('puppeteer'); ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ebidel
Copy link
Contributor Author

ebidel commented Aug 24, 2017

Is missing 'use strict'; intended in all the examples?

Think it's an oversite. We probably should add that.

@vsemozhetbyt
Copy link
Contributor

@ebidel Maybe also in the test. Maybe all the non-module scripts need to be checked.

@ebidel
Copy link
Contributor Author

ebidel commented Aug 24, 2017

Sure, let's leave that for a separate PR though :)

aslushnikov
aslushnikov approved these changes Aug 25, 2017
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we call the example expose-function.js?

@ebidel
Copy link
Contributor Author

ebidel commented Aug 25, 2017

@aslushnikov naw, I'd rather examples be use case driven than match api names. People will be searching for examples on how to get something done.

@ebidel ebidel merged commit 4e3b6a1 into master Aug 25, 2017
@ebidel ebidel deleted the customeventexample branch August 25, 2017 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ebidel @vsemozhetbyt @aslushnikov