Docker example #721
Merged
Docker example #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Sep 8, 2017
| # Install puppeteer so it can be required by user code that gets ran in server.js. | ||
| RUN yarn add puppeteer | ||
|
|
||
| CMD ["google-chrome-unstable", "--no-sandbox"] |
There was a problem hiding this comment.
Yea, I think you have to have a default CMD or ENTRYPOINT.
| docker build -t puppeteer-chrome-linux . | ||
| ``` | ||
|
|
||
| Run the container by passing `node -e "<yourscript.js content as a string>` as the command: |
There was a problem hiding this comment.
You can also mount the current folder inside the container and run node there.
Example
There was a problem hiding this comment.
I thought about that. The problem is if you run this on App Engine (possibly others), there's no way to control the run command. It runs yarn start for you. That's why I made something that also works well with a server endpoint: https://github.com/ebidel/try-puppeteer#running-the-container
aslushnikov
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.