feat(console): dispatch JSHandles as console arguments #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch starts dispatching JSHandle instances as console arguments. BREAKING CHANGE: this changes the API of the ConsoleMessage. Fixes puppeteer#324.
vsemozhetbyt
reviewed
Oct 6, 2017
| @@ -1161,7 +1161,7 @@ Dialog's type, could be one of the `alert`, `beforeunload`, `confirm` and `promp | |||
| [ConsoleMessage] objects are dispatched by page via the ['console'](#event-console) event. | |||
|
|
|||
| #### consoleMessage.args | |||
| - <[Array]<[string]>> | |||
| - <[Array]<[JSHandle]>> | |||
There was a problem hiding this comment.
FWIW, this link is somehow broken here and in some other places.
There was a problem hiding this comment.
@vsemozhetbyt thanks, fixed in 3214bb7
JoelEinbinder
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch starts dispatching JSHandle instances as console arguments.
In doing so, we no longer do hops to the page to serialize page arguments, which
removes races between events.
BREAKING CHANGE: this changes the API of the ConsoleMessage.
Fixes #324.