Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the failing tests pass #50

Closed
addyosmani opened this issue Oct 18, 2016 · 1 comment
Closed

Make the failing tests pass #50

addyosmani opened this issue Oct 18, 2016 · 1 comment
Assignees
Labels
Infrastructure Related to the helper and utility scripts in the project.

Comments

@addyosmani
Copy link
Member

It's harder to understand the impact of new changes (and existing issues) with sub-projects when the tests have been failing for a while. Let's see if we can get them passing again before adding in new work. Right now it's hard to understand when the tests last actually went green (maybe 3 months ago? :))

Matt was up for trying to get the tests passing. Locally we're all green now on the appcache behavior. Just need to go green on offline analytics before that work lands.

@addyosmani addyosmani added this to the Chrome Dev Summit 2016 milestone Oct 18, 2016
@addyosmani addyosmani added the Infrastructure Related to the helper and utility scripts in the project. label Oct 18, 2016
@gauntface gauntface mentioned this issue Oct 18, 2016
@gauntface
Copy link

All tests are fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Related to the helper and utility scripts in the project.
Projects
None yet
Development

No branches or pull requests

2 participants