Exclude the file passed to write() from being picked up #107
Conversation
|
Change LGTM. Would be good to get a quick check from Stuart as I think his tweet was in ref to this issue. |
|
Works for me! |
| // Return null if we want to exclude this file, and it will be excluded in | ||
| // the subsequent filter(). | ||
| return excludeFilePath === absolutePath(file) ? | ||
| null : |
There was a problem hiding this comment.
Is there a reason not to just do this exclude check in the filter?
There was a problem hiding this comment.
You save an unneeded fs.statSync() by filtering it out early and avoiding the call to getFileAndSizeAndHashForFile(). That was the main reason.
There was a problem hiding this comment.
Koolio - ta Jeff.
On Thu, 21 Apr 2016, 15:51 Jeffrey Posnick, notifications@github.com
wrote:
In lib/sw-precache.js
#107 (comment)
:return glob.sync(globPattern.replace(path.sep, '/')).map(function(file) {
- return getFileAndSizeAndHashForFile(file);
- // Return null if we want to exclude this file, and it will be excluded in
- // the subsequent filter().
- return excludeFilePath === absolutePath(file) ?
null :You save an unneeded fs.statSync() by filtering it out early and avoiding
the call to getFileAndSizeAndHashForFile(). That was the main reason.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/GoogleChrome/sw-precache/pull/107/files/be0bd63f40fea5dcd5efa1cf799fb47d43afebe6#r60594149
|
Lgtm apart from one comment |
|
Looks like we have two LGTMs and Matt's comment was responded to :) |
R: @gauntface @wibblymat @addyosmani
CC: @stuartlangridge
This ensures that a previously generated version of the service worker output file isn't picked up in the list of files to be precached.
Insert "We need to go deeper!" meme here.
Fixes #101