Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Cli : set defaults : field stripPrefixMulti #213

Merged
merged 1 commit into from Nov 16, 2016

Conversation

Fridus
Copy link
Contributor

@Fridus Fridus commented Nov 16, 2016

The field stripPrefixMulti not working when we use the command-line interface

The field `stripPrefixMulti` not working when we use the command-line interface
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jeffposnick
Copy link
Contributor

👍 Thanks!

@jeffposnick jeffposnick merged commit 3ba28f9 into GoogleChromeLabs:master Nov 16, 2016
@Fridus
Copy link
Contributor Author

Fridus commented Nov 17, 2016

Hi @jeffposnick !
Could you make a release please ? I need this fix for my project ;)

@jeffposnick
Copy link
Contributor

@Fridus Yes, I can cut a release soon.

But in the meantime, have you just considered using the --config=<file> option, and putting your configuration (including stripPrefixMulti) inside a file? There's an example at https://github.com/GoogleChrome/sw-precache/#command-line-interface showing how a file with module.exports can be used.

I think you're going to have a much better time using that whenever possible.

@jeffposnick
Copy link
Contributor

FYI, 4.2.2 should now be available on npm, and includes your PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants