This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Support for the dontCacheBustUrlsMatching option in the CLI. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyosmani
reviewed
Nov 23, 2016
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "sw-precache", | |||
| "version": "4.2.2", | |||
| "version": "4.2.3", | |||
There was a problem hiding this comment.
Generally suggest not bumping package versions in feature PRs, but you know what you're doing :)
There was a problem hiding this comment.
Okay, good practice for the future.
addyosmani
approved these changes
Nov 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
Another one in the get-a-config-option-working-in-the-CLI vein.