This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Removes console.log()s from the generated SW #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thank you. |
|
+1 this change. |
|
👍 |
jeffposnick
added a commit
that referenced
this pull request
Dec 4, 2015
Removes console.log()s from the generated SW
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @gauntface @addyosmani @wibblymat
CC: @seanislegend
These log statements were mainly useful ~1 year ago when the service worker DevTools situation was much more, and you really needed logging to figure out what was going on regarding your caches. Things have improved (in Chrome) since then, and I think we can just drop this noise.
The existing
verboseoption is meant for toggling build-time logging, not run-time logging. I'd rather not creating aruntime-verboseoption.Closes #60